Merge branch 'feature/facade-runtime' into 'master'

adds runtime

See merge request !8

.gitlab-ci.yml

@@ -6,15 +6,11 @@ before_script:
   - export PYENV_ROOT="$HOME/.pyenv"
   - export PATH="$PYENV_ROOT/bin:$PATH"
   - eval "$(pyenv init -)"
+  - export CFLAGS=-I/usr/include/openssl
+  - export LDFLAGS=-L/usr/lib
   # Install tox
   - pip install tox
 
-test:python26:
-  script:
-  - pyenv install 2.6.9
-  - pyenv shell 2.6.9
-  - tox -e py26-normal
-
 test:python27:
   script:
   - pyenv install 2.7.14
@@ -23,6 +19,7 @@ test:python27:
 
 test:python34:
   script:
+  - apt-get install -y libssl1.0-dev
   - pyenv install 3.4.7
   - pyenv shell 3.4.7
   - tox -e py34-normal

FACADE.rst

@@ -30,6 +30,7 @@ Get a title
 Returns a ``Title`` object with the following attributes:
 
 -  certification
+-  runtime
 -  creators
 -  credits
 -  directors

HISTORY.rst

@@ -3,17 +3,17 @@
 Release History
 ---------------
 
-5.5.1 (unreleased)
+5.6.9 (unreleased)
 ++++++++++++++++++
 
-- Nothing changed yet.
+- Adds ``runtime`` attribute to ``ImdbFacade``.
 
 
 5.5.0 (2018-05-27)
 ++++++++++++++++++
 
 - Adds ``get_title_auxiliary`` method to client.
-- Adds `ImdbFacade` facade for API.
+- Adds ``ImdbFacade`` facade for API.
 
 
 5.4.5 (2018-04-29)

src/imdbpie/facade.py

@@ -21,6 +21,10 @@ class ImdbFacade(object):
 
     def get_title(self, imdb_id):
         title_data, title_aux_data = self._get_title_data(imdb_id=imdb_id)
+        try:
+            runtime = title_aux_data['runningTimes'][0]['timeMinutes']
+        except (KeyError, IndexError):
+            runtime = None
         try:
             episodes = TitleEpisodes(facade=self, imdb_id=imdb_id)
         except LookupError:
@@ -32,7 +36,8 @@ class ImdbFacade(object):
             season = None
             episode = None
         return Title(
-            season=season, episode=episode, episodes=episodes, **title_data
+            season=season, episode=episode, episodes=episodes,
+            runtime=runtime, **title_data
         )
 
     def get_name(self, imdb_id):

src/imdbpie/objects.py

@@ -55,6 +55,7 @@ class Title(object):
     rating = attr.ib(default=None)
     plot_outline = attr.ib(default=None)
     release_date = attr.ib(default=None)
+    runtime = attr.ib(default=None)
 
     def __repr__(self):
         return 'Title(imdb_id={0}, title={1})'.format(self.imdb_id, self.title)

src/tests/test_facade.py

@@ -23,6 +23,8 @@ class TestGetTitle(object):
         assert isinstance(title, Title)
         _check_title(title=title, facade=facade)
         assert title.type == 'tvseries'
+        assert isinstance(title.runtime, int)
+        assert title.runtime > 0
 
         num_checked = 0
         for episode in title.episodes:
@@ -50,6 +52,8 @@ class TestGetTitle(object):
         _check_title(title=title, facade=facade)
         assert title.type == 'movie'
         assert len(title.episodes) == 0
+        assert isinstance(title.runtime, int)
+        assert title.runtime > 0
 
     @pytest.mark.parametrize('imdb_id', [
         'tt0795176',
@@ -62,6 +66,8 @@ class TestGetTitle(object):
         _check_title(title=title, facade=facade)
 
         assert title.type in ('tvminiseries', 'movie')
+        assert isinstance(title.runtime, int)
+        assert title.runtime > 0
 
         num_checked = 0
         for episode in title.episodes:
@@ -79,6 +85,8 @@ class TestGetTitle(object):
         title = facade.get_title(imdb_id=episode_imdb_id)
 
         assert isinstance(title, Title)
+        assert isinstance(title.runtime, int)
+        assert title.runtime > 0
         assert title.imdb_id == episode_imdb_id
         assert len(title.episodes) == 0
         assert isinstance(title.season, int)